Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

DatatypeUnitResources Controller Refactor with Integration Testing for OpenTSDB#315

Merged
adamkorynta merged 8 commits into
opendcs:feature/task_cwms_supportfrom
zack-rma:feature/task_cwms_support_datatypeunit_resources_it
Feb 5, 2025
Merged

DatatypeUnitResources Controller Refactor with Integration Testing for OpenTSDB#315
adamkorynta merged 8 commits into
opendcs:feature/task_cwms_supportfrom
zack-rma:feature/task_cwms_support_datatypeunit_resources_it

Conversation

@zack-rma

@zack-rma zack-rma commented Jan 3, 2025

Copy link
Copy Markdown
Collaborator

Problem Description

Fixes #314.

Solution

Implements integration testing for DatatypeUnitResources against OpenTSDB instance.

how you tested the change

Integration testing included.

Where the following done:

  • Tests. Check all that apply:
    • Unit tests created or modified that run during ant test.
    • Integration tests created or modified that run during integration testing
      (Formerly called regression tests.)
    • Test procedure descriptions for manual testing
  • Was relevant documentation updated?
  • Were relevant config element (e.g. XML data) updated as appropriate

If you aren't sure leave unchecked and we will help guide you to want needs changing where.

@zack-rma zack-rma force-pushed the feature/task_cwms_support_datatypeunit_resources_it branch from 9e52ee3 to d9933ef Compare January 3, 2025 17:08
@zack-rma

Copy link
Copy Markdown
Collaborator Author

OpenDCS Toolkit changes can be found here: adamkorynta/opendcs#2

Deletion bug and Toolkit support for UnitConverter deletion on XML DB in progress.

@zack-rma zack-rma changed the title Integration Testing for DatatypeUnitResources Controller DatatypeUnitResources Controller Refactor with Integration Testing for OpenTSDB Jan 10, 2025
@zack-rma zack-rma self-assigned this Jan 16, 2025
@zack-rma

Copy link
Copy Markdown
Collaborator Author

Deletion bug resolved

@zack-rma zack-rma marked this pull request as ready for review January 17, 2025 19:24
@zack-rma zack-rma requested a review from rma-rripken January 17, 2025 19:24
Comment thread opendcs-rest-api/src/main/java/org/opendcs/odcsapi/res/DatatypeUnitResources.java Outdated
@zack-rma zack-rma force-pushed the feature/task_cwms_support_datatypeunit_resources_it branch from 2e436b4 to a1ca429 Compare January 29, 2025 18:37
adamkorynta added a commit that referenced this pull request Jan 30, 2025
@zack-rma zack-rma force-pushed the feature/task_cwms_support_datatypeunit_resources_it branch from a1ca429 to 8a53e99 Compare January 30, 2025 22:38
@zack-rma zack-rma force-pushed the feature/task_cwms_support_datatypeunit_resources_it branch from 44b2243 to 9b206bc Compare January 31, 2025 22:06
@sonarqubecloud

sonarqubecloud Bot commented Feb 4, 2025

Copy link
Copy Markdown

@adamkorynta adamkorynta merged commit 386bdd1 into opendcs:feature/task_cwms_support Feb 5, 2025
@zack-rma zack-rma removed their assignment Feb 10, 2025
adamkorynta pushed a commit that referenced this pull request Mar 13, 2025
…r OpenTSDB (#315)

Implemented DatatypeUnitResources Controller refactor
adamkorynta pushed a commit that referenced this pull request Mar 24, 2025
…r OpenTSDB (#315)

Implemented DatatypeUnitResources Controller refactor
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

OpenTSDB: Create Integration Tests for DatatypeUnitResources controller Refactor DatatypeUnitResources controller

3 participants